Skip to content

[Snyk] Fix for 1 vulnerabilities #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
+2 −2
Closed

[Snyk] Fix for 1 vulnerabilities #4470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/stack-overflow-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +35 to +37
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace references with fixed versions in a monorepo can lead to dependency resolution conflicts. This approach breaks the internal dependency management that workspace references provide, where packages automatically use the latest local versions.

The PR description also indicates that the yarn.lock file wasn't updated properly. Before merging, it's important to:

  1. Run yarn to regenerate the lockfile with these changes
  2. Consider whether fixed versions are appropriate in this context - typically in monorepos, workspace references (workspace:^) are used intentionally to ensure internal packages stay in sync

If the vulnerability fix is necessary, consider upgrading the affected dependencies while maintaining workspace references, or follow your team's established approach for handling security updates in the monorepo.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"node-fetch": "^2.6.7",
"qs": "^6.9.4",
"winston": "^3.2.1"
Expand Down
Loading