Skip to content

[Snyk] Fix for 1 vulnerabilities #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app-defaults/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/core-app-api": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +39
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references (workspace:^) with fixed versions, which disrupts the Backstage monorepo architecture. In a monorepo setup, workspace references ensure that packages use local versions of dependencies, enabling coordinated development and testing.

Fixed versions like 0.1.0 and 0.1.1 are likely outdated and will cause version mismatches across the project. While addressing the tar-fs vulnerability is important, it should be done while preserving the workspace references.

Consider addressing the vulnerability by updating the affected dependency in its source package instead, which would propagate through the workspace references while maintaining the monorepo integrity.

Suggested change
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1"
},
Expand Down
Loading