Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@backstage/config": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a potential dependency conflict in the Backstage monorepo. Replacing the workspace reference (workspace:^) with a pinned version (0.1.0) breaks the monorepo's dependency management pattern and could lead to duplicate package installations.

The PR description also notes that the yarn.lock file wasn't updated successfully, which means the dependency change won't be properly reflected in the dependency tree.

For Backstage monorepos, the recommended approach is to:

  1. Keep the workspace reference syntax (workspace:^)
  2. Update the version in the target package's own package.json
  3. Allow Backstage's monorepo tooling to handle dependency resolution

This ensures consistent versioning across the monorepo while still addressing the security vulnerability.

Suggested change
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"uuid": "^8.0.0",
Expand Down
Loading