Skip to content

[Snyk] Fix for 41 vulnerabilities #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 41 vulnerabilities #4520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/search-backend-module-catalog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^"
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1"
Comment on lines +41 to +48
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace:^ references with fixed versions in a Yarn workspace monorepo can lead to dependency inconsistencies. This approach breaks the workspace linking mechanism that ensures all packages use the same version of internal dependencies.

The warning in the PR description ("Failed to update the yarn.lock") further indicates these changes aren't properly synchronized with the project's dependency tree.

For monorepo health, consider:

  1. Keeping the workspace:^ references for internal packages
  2. If vulnerability fixes are needed, update the packages at their source within the monorepo
  3. If fixed versions are absolutely necessary, ensure all related packages are updated consistently and the yarn.lock is properly regenerated

This approach will maintain dependency consistency while addressing the security vulnerabilities.

Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^"
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1"
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

},
"devDependencies": {
"@backstage/backend-common": "workspace:^",
Expand Down
Loading