Skip to content

[Snyk] Fix for 41 vulnerabilities #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 41 vulnerabilities #4526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-msgraph/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
"@azure/identity": "^3.2.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +51 to +55
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version numbers being introduced in this PR are concerning. The PR is replacing workspace references with fixed, very old versions:

  • @backstage/catalog-model: 0.1.1 (current stable is ~1.4)
  • @backstage/plugin-catalog-common: 0.1.0 (current stable is ~1.0)
  • @backstage/backend-tasks: 0.6.1 (current stable is ~0.5)
  • @backstage/plugin-catalog-node: 1.0.0 (current stable is ~1.4)

These versions are inconsistent with each other and significantly outdated, which will likely cause compatibility issues with the rest of the codebase.

While fixing vulnerabilities is important, it should be done by updating to recent, compatible versions rather than downgrading to very old ones. Consider either:

  1. Maintaining the workspace references and updating the root dependencies
  2. Using recent, compatible fixed versions if workspace references aren't appropriate

This approach would address the vulnerabilities without introducing version incompatibilities.

Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@microsoft/microsoft-graph-types": "^2.6.0",
"@types/node-fetch": "^2.5.12",
"lodash": "^4.17.21",
Expand Down
Loading