Skip to content

[Snyk] Fix for 1 vulnerabilities#4532

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-3581d203441615ea834cbf5c83db0123
Closed

[Snyk] Fix for 1 vulnerabilities#4532
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-3581d203441615ea834cbf5c83db0123

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Apr 12, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/jenkins-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITREQUESTERROR-8730854
  67  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update dependencies to fix a security vulnerability in the Jenkins backend plugin

Bug Fixes:

  • Fix a Regular Expression Denial of Service (ReDoS) vulnerability in project dependencies

Enhancements:

  • Update @backstage/config and @backstage/plugin-permission-node to specific versions to address security issues

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 12, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented Apr 12, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 12, 2025

Reviewer's Guide by Sourcery

This pull request updates @backstage/config and @backstage/plugin-permission-node in plugins/jenkins-backend/package.json to address a Regular Expression Denial of Service (ReDoS) vulnerability.

Updated class diagram for package.json dependencies

classDiagram
  class package_json {
    - "@backstage/config": "0.1.1"
    - "@backstage/plugin-permission-node": "0.1.0"
  }
  note for package_json "Updates @backstage/config and @backstage/plugin-permission-node to address ReDoS vulnerability"
Loading

File-Level Changes

Change Details Files
Updates @backstage/config and @backstage/plugin-permission-node to address a Regular Expression Denial of Service (ReDoS) vulnerability.
  • Updates @backstage/config from workspace:^ to 0.1.1.
  • Updates @backstage/plugin-permission-node from workspace:^ to 0.1.0.
plugins/jenkins-backend/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Comment on lines +30 to +35
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-jenkins-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is replacing workspace:^ references with fixed versions (0.1.1 and 0.1.0), which breaks the monorepo dependency management. This explains the yarn.lock update failure mentioned in the warning.

In a Backstage monorepo, workspace references ensure packages use compatible versions from the same codebase. Pinning to specific versions defeats this purpose and may cause compatibility issues with other internal packages.

To properly fix the vulnerability:

  1. Update the vulnerable dependency in the root package.json
  2. Keep the workspace:^ references intact in this file
  3. Run yarn to update lockfiles correctly

This approach maintains the workspace integrity while addressing the security concern.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-jenkins-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-jenkins-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 19, 2025
@github-actions github-actions Bot closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants