Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-OCTOKITREQUESTERROR-8730854
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's Guide by SourceryThis pull request updates Updated class diagram for package.json dependenciesclassDiagram
class package_json {
- "@backstage/config": "0.1.1"
- "@backstage/plugin-permission-node": "0.1.0"
}
note for package_json "Updates @backstage/config and @backstage/plugin-permission-node to address ReDoS vulnerability"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
| "@backstage/config": "0.1.1", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-auth-node": "workspace:^", | ||
| "@backstage/plugin-jenkins-common": "workspace:^", | ||
| "@backstage/plugin-permission-common": "workspace:^", | ||
| "@backstage/plugin-permission-node": "workspace:^", | ||
| "@backstage/plugin-permission-node": "0.1.0", |
There was a problem hiding this comment.
The PR is replacing workspace:^ references with fixed versions (0.1.1 and 0.1.0), which breaks the monorepo dependency management. This explains the yarn.lock update failure mentioned in the warning.
In a Backstage monorepo, workspace references ensure packages use compatible versions from the same codebase. Pinning to specific versions defeats this purpose and may cause compatibility issues with other internal packages.
To properly fix the vulnerability:
- Update the vulnerable dependency in the root package.json
- Keep the
workspace:^references intact in this file - Run yarn to update lockfiles correctly
This approach maintains the workspace integrity while addressing the security concern.
| "@backstage/config": "0.1.1", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-auth-node": "workspace:^", | |
| "@backstage/plugin-jenkins-common": "workspace:^", | |
| "@backstage/plugin-permission-common": "workspace:^", | |
| "@backstage/plugin-permission-node": "workspace:^", | |
| "@backstage/plugin-permission-node": "0.1.0", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-auth-node": "workspace:^", | |
| "@backstage/plugin-jenkins-common": "workspace:^", | |
| "@backstage/plugin-permission-common": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/jenkins-backend/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-OCTOKITREQUESTERROR-8730854
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Summary by Sourcery
Update dependencies to fix a security vulnerability in the Jenkins backend plugin
Bug Fixes:
Enhancements: