Skip to content

[Snyk] Fix for 2 vulnerabilities #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/tech-insights-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
Comment on lines +36 to 42
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces inconsistency by changing only some dependencies from workspace references (workspace:^) to specific versions while leaving others unchanged. This mixed approach could lead to compatibility issues between packages that expect to work with aligned versions.

The warning in the PR description about the failed yarn.lock update is also concerning, as it indicates the dependency changes haven't been properly validated.

For a more reliable fix:

  1. Either update all dependencies consistently (all specific versions or all workspace references)
  2. Ensure the specific versions chosen (0.24.1, 0.6.1, 0.2.0, 0.1.1) are compatible with the workspace versions of remaining dependencies
  3. Properly update the yarn.lock file before merging

Since this PR aims to fix security vulnerabilities, addressing these inconsistencies is important to ensure the fix doesn't introduce new problems.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Expand Down
Loading