Skip to content

[Snyk] Fix for 2 vulnerabilities #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/search-backend-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +40 to +45
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace references with pinned versions, which could introduce compatibility issues in the monorepo. While addressing the vulnerabilities is important, changing from workspace:^ to specific versions (0.1.0, 0.6.1, 0.3.1) may cause version mismatches with other packages.

The warning in the PR description about failing to update the yarn.lock file is also concerning and needs to be resolved before merging.

Consider:

  1. Maintaining workspace references while updating the underlying dependencies
  2. Ensuring the yarn.lock file is properly updated
  3. Testing the changes thoroughly to verify no regressions occur from these dependency updates
Suggested change
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/lunr": "^2.3.3",
"lodash": "^4.17.21",
"lunr": "^2.3.9",
Expand Down
Loading