Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/techdocs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-search-react": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing a workspace dependency with a fixed version (0.1.0) breaks the monorepo's dependency management pattern and may cause compatibility issues. The PR description indicates the yarn.lock update failed, which is a critical warning sign.

For Backstage monorepos, the recommended approach is to:

  1. Keep the workspace reference syntax (workspace:^)
  2. Update the root package.json to specify the minimum version requirement
  3. Run yarn to properly update all dependencies and regenerate yarn.lock

This ensures the security vulnerabilities are addressed while maintaining compatibility with the monorepo structure and other Backstage plugins.

# Example of proper approach in root package.json
"resolutions": {
  "@backstage/plugin-search-react": "^0.1.0"
}
Suggested change
"@backstage/plugin-search-react": "0.1.0",
"@backstage/plugin-search-react": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading