Skip to content

[Snyk] Fix for 2 vulnerabilities #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
+2 −2
Closed

[Snyk] Fix for 2 vulnerabilities #4609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/sonarqube-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",
Comment on lines +25 to +27
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace references with fixed versions, which disrupts the project's workspace architecture. This approach:

  1. Breaks the local dependency resolution that workspaces provide
  2. May introduce duplicate package installations
  3. Could create version compatibility issues across the project

The warning about failing to update yarn.lock confirms these concerns.

A more sustainable approach would be to:

  • Use Snyk to identify the vulnerabilities
  • Update the vulnerable dependencies within the workspace packages themselves
  • Maintain the workspace:^ references to preserve the monorepo structure

This ensures the security fixes are applied while maintaining the project's dependency architecture.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/express": "*",
"express": "^4.18.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading