[Snyk] Fix for 2 vulnerabilities#4624
Conversation
…nerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691387 - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's Guide by SourceryThis pull request upgrades three packages in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
| "@backstage/backend-tasks": "0.6.1", | ||
| "@backstage/catalog-client": "workspace:^", | ||
| "@backstage/catalog-model": "workspace:^", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/plugin-catalog-common": "workspace:^", | ||
| "@backstage/plugin-catalog-common": "0.1.0", | ||
| "@backstage/plugin-permission-common": "workspace:^", | ||
| "@backstage/plugin-search-backend-node": "workspace:^", | ||
| "@backstage/plugin-search-common": "workspace:^" | ||
| "@backstage/plugin-search-common": "0.3.1" |
There was a problem hiding this comment.
This PR replaces workspace:^ references with pinned versions, which breaks the Backstage monorepo dependency structure. In Backstage monorepos, internal package dependencies should use workspace references to maintain consistency across the codebase.
Pinning to specific versions (particularly older ones like 0.1.0) will likely cause compatibility issues with other components. The vulnerabilities in http-proxy-middleware should be addressed at the root level package.json rather than by pinning individual package versions.
Consider reverting these changes to maintain the workspace:^ references, and instead update the vulnerable dependency at the root level where it's actually defined. This approach will preserve the monorepo integrity while still addressing the security concerns.
| "@backstage/backend-tasks": "0.6.1", | |
| "@backstage/catalog-client": "workspace:^", | |
| "@backstage/catalog-model": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/plugin-catalog-common": "workspace:^", | |
| "@backstage/plugin-catalog-common": "0.1.0", | |
| "@backstage/plugin-permission-common": "workspace:^", | |
| "@backstage/plugin-search-backend-node": "workspace:^", | |
| "@backstage/plugin-search-common": "workspace:^" | |
| "@backstage/plugin-search-common": "0.3.1" | |
| "@backstage/backend-tasks": "workspace:^", | |
| "@backstage/catalog-client": "workspace:^", | |
| "@backstage/catalog-model": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/plugin-catalog-common": "workspace:^", | |
| "@backstage/plugin-permission-common": "workspace:^", | |
| "@backstage/plugin-search-backend-node": "workspace:^", | |
| "@backstage/plugin-search-common": "workspace:^" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/search-backend-module-catalog/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Sourcery
Update dependencies to fix security vulnerabilities in the search backend catalog module
Bug Fixes:
Enhancements: