Skip to content

[Snyk] Fix for 2 vulnerabilities #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app-defaults/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/core-app-api": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +39
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed dependency changes introduce significant issues by replacing workspace references with pinned, outdated versions. Changing workspace:^ to specific versions (0.1.0 and 0.1.1) breaks the local development workflow and module linking that the workspace references provide.

These versions are extremely old and incompatible with the current codebase. The warning about failing to update yarn.lock confirms these changes aren't properly resolved in the dependency tree.

To properly address the vulnerabilities:

  1. Maintain the workspace:^ references
  2. Update the underlying dependencies that contain http-proxy-middleware in the project root
  3. Let Yarn's workspace resolution handle propagating the fixed versions

This preserves the monorepo structure while addressing the security issues in a way that won't break the application.

Suggested change
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1"
},
Expand Down
Loading