Closed
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691387 - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's Guide by SourceryThis pull request updates the Updated class diagram for package.json dependenciesclassDiagram
class PackageJson {
-dependencies: Object
}
PackageJson --|> BackendAppApi
PackageJson --|> BackendPluginApi
PackageJson --|> IntegrationAwsNode
class BackendAppApi {
-version: string
+getVersion(): string
}
note for BackendAppApi "Updated from workspace:^ to 0.7.6"
class BackendPluginApi {
-version: string
+getVersion(): string
}
note for BackendPluginApi "Updated from workspace:^ to 0.6.19"
class IntegrationAwsNode {
-version: string
+getVersion(): string
}
note for IntegrationAwsNode "Updated from workspace:^ to 0.1.0"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+53
to
+61
| "@backstage/backend-app-api": "0.7.6", | ||
| "@backstage/backend-dev-utils": "workspace:^", | ||
| "@backstage/backend-plugin-api": "workspace:^", | ||
| "@backstage/backend-plugin-api": "0.6.19", | ||
| "@backstage/cli-common": "workspace:^", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/config-loader": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/integration": "workspace:^", | ||
| "@backstage/integration-aws-node": "workspace:^", | ||
| "@backstage/integration-aws-node": "0.1.0", |
There was a problem hiding this comment.
The PR is attempting to fix vulnerabilities by replacing workspace references (workspace:^) with fixed version numbers, but this approach has significant drawbacks in a monorepo setup:
- Replacing
workspace:^references with fixed versions breaks local development workflows in Yarn workspaces - With fixed versions, changes in one package won't be immediately available to dependent packages
- The PR itself notes a failure to update the yarn.lock file, which is concerning
A more appropriate approach would be to:
- Keep the workspace references intact
- Update the vulnerable dependencies within their respective packages
- Ensure the yarn.lock file is properly updated
This maintains the monorepo development experience while still addressing the security vulnerabilities in http-proxy-middleware.
Suggested change
| "@backstage/backend-app-api": "0.7.6", | |
| "@backstage/backend-dev-utils": "workspace:^", | |
| "@backstage/backend-plugin-api": "workspace:^", | |
| "@backstage/backend-plugin-api": "0.6.19", | |
| "@backstage/cli-common": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/config-loader": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/integration": "workspace:^", | |
| "@backstage/integration-aws-node": "workspace:^", | |
| "@backstage/integration-aws-node": "0.1.0", | |
| "@backstage/backend-app-api": "workspace:^", | |
| "@backstage/backend-dev-utils": "workspace:^", | |
| "@backstage/backend-plugin-api": "workspace:^", | |
| "@backstage/cli-common": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/config-loader": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/integration": "workspace:^", | |
| "@backstage/integration-aws-node": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/backend-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Sourcery
Update dependencies to fix Snyk vulnerabilities in http-proxy-middleware package
Bug Fixes:
Enhancements: