Skip to content

[Snyk] Fix for 2 vulnerabilities #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/backend-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@
"@aws-sdk/client-s3": "^3.350.0",
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/types": "^3.347.0",
"@backstage/backend-app-api": "workspace:^",
"@backstage/backend-app-api": "0.7.6",
"@backstage/backend-dev-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/integration-aws-node": "0.1.0",
Comment on lines +53 to +61

@graphite-app graphite-app Bot Apr 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is attempting to fix vulnerabilities by replacing workspace references (workspace:^) with fixed version numbers, but this approach has significant drawbacks in a monorepo setup:

  1. Replacing workspace:^ references with fixed versions breaks local development workflows in Yarn workspaces
  2. With fixed versions, changes in one package won't be immediately available to dependent packages
  3. The PR itself notes a failure to update the yarn.lock file, which is concerning

A more appropriate approach would be to:

  • Keep the workspace references intact
  • Update the vulnerable dependencies within their respective packages
  • Ensure the yarn.lock file is properly updated

This maintains the monorepo development experience while still addressing the security vulnerabilities in http-proxy-middleware.

Suggested change
"@backstage/backend-app-api": "0.7.6",
"@backstage/backend-dev-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/integration-aws-node": "0.1.0",
"@backstage/backend-app-api": "workspace:^",
"@backstage/backend-dev-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@google-cloud/storage": "^6.0.0",
"@keyv/memcache": "^1.3.5",
Expand Down