Skip to content

[Snyk] Fix for 3 vulnerabilities #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #4693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-bitbucket/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +36 to +42
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR replaces workspace references (workspace:^) with pinned versions, which disrupts the monorepo architecture. In a Yarn workspace, these references ensure packages use local versions, maintaining consistency across the project.

Pinning to specific versions like "@backstage/backend-common": "0.24.1" can cause:

  • Duplicate package instances
  • Dependency resolution conflicts
  • Inconsistent behavior between packages

The warning in the PR description about failing to update yarn.lock further indicates these changes aren't properly integrated with the dependency graph.

A better approach would be to address the vulnerabilities by updating the shared packages within the monorepo while preserving the workspace references. This maintains the integrity of the monorepo structure while still addressing the security concerns.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading