[Snyk] Fix for 2 vulnerabilities#4694
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691387 - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's Guide by SourceryThis pull request updates the Updated class diagram for package.json dependenciesclassDiagram
class PackageJson {
dependencies
}
PackageJson --|> Dependency
class Dependency {
+@backstage/config: string
+@backstage/core-plugin-api: string
+@backstage/types: string
+@backstage/version-bridge: string
+@types/prop-types: string
+@types/react: string
+history: string
+react: string
+react-dom: string
+react-router: string
+react-router-dom: string
+single-spa: string
+single-spa-react: string
}
note for Dependency "@backstage/config, @backstage/core-plugin-api, and @backstage/version-bridge dependencies have been updated to specific versions from workspace:^"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@backstage/config": "0.1.1", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/types": "workspace:^", | ||
| "@backstage/version-bridge": "workspace:^", | ||
| "@backstage/version-bridge": "0.1.0", |
There was a problem hiding this comment.
This PR attempts to fix vulnerabilities by replacing workspace references with pinned versions, but the specified versions are significantly outdated. For example:
@backstage/core-plugin-apiis being pinned to0.1.0when the current version is1.5.3@backstage/configis being pinned to0.1.1when the current version is1.0.8
These extremely outdated versions will likely cause runtime errors due to API incompatibilities. While addressing the vulnerabilities is important, a better approach would be to use more recent versions that fix the security issues without introducing compatibility problems.
Consider rejecting this PR and requesting an update that uses current or near-current versions that address the http-proxy-middleware vulnerabilities without downgrading the entire dependency chain to early alpha versions.
| "@backstage/config": "0.1.1", | |
| "@backstage/core-plugin-api": "0.1.0", | |
| "@backstage/types": "workspace:^", | |
| "@backstage/version-bridge": "workspace:^", | |
| "@backstage/version-bridge": "0.1.0", | |
| "@backstage/config": "^1.0.8", | |
| "@backstage/core-plugin-api": "^1.5.3", | |
| "@backstage/types": "workspace:^", | |
| "@backstage/version-bridge": "^1.0.0", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/core-app-api/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Sourcery
Update dependencies to fix Snyk security vulnerabilities in http-proxy-middleware package
Bug Fixes:
Enhancements: