Skip to content

[Snyk] Fix for 2 vulnerabilities #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core-app-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
Comment on lines +35 to +38
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix vulnerabilities by replacing workspace references with pinned versions, but the specified versions are significantly outdated. For example:

  • @backstage/core-plugin-api is being pinned to 0.1.0 when the current version is 1.5.3
  • @backstage/config is being pinned to 0.1.1 when the current version is 1.0.8

These extremely outdated versions will likely cause runtime errors due to API incompatibilities. While addressing the vulnerabilities is important, a better approach would be to use more recent versions that fix the security issues without introducing compatibility problems.

Consider rejecting this PR and requesting an update that uses current or near-current versions that address the http-proxy-middleware vulnerabilities without downgrading the entire dependency chain to early alpha versions.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
"@backstage/config": "^1.0.8",
"@backstage/core-plugin-api": "^1.5.3",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "^1.0.0",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/prop-types": "^15.7.3",
"@types/react": "^16.13.1 || ^17.0.0",
"history": "^5.0.0",
Expand Down
Loading