Skip to content

[Snyk] Fix for 2 vulnerabilities #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #4710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-gitlab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing @backstage/plugin-catalog-node from workspace:^ to a fixed version 1.0.0 may introduce compatibility issues. This module directly imports from this package and relies on its APIs. In Backstage's monorepo structure, workspace references ensure consistent dependency resolution across modules. Pinning to a specific version breaks this pattern and could cause conflicts with other Backstage modules that expect workspace-based resolution. Consider maintaining the workspace:^ reference to preserve compatibility with the rest of the ecosystem.

Suggested change
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading