Skip to content

[Snyk] Fix for 49 vulnerabilities #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 49 vulnerabilities #4747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/search-backend-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +40 to +45
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace references to pinned versions (0.1.0, 0.6.1, 0.3.1) may introduce compatibility issues with the rest of the project. These specific versions could be outdated compared to what's currently used in the workspace.

The PR description also notes that the yarn.lock file failed to update, which is concerning as it means these dependency changes won't be properly reflected in the lock file, potentially leading to inconsistent builds.

Consider either:

  1. Maintaining the workspace references (workspace:^) to ensure consistency across the project
  2. Ensuring all related dependencies are updated consistently and that the yarn.lock file is properly updated

This approach would help maintain compatibility while addressing the security vulnerabilities that Snyk identified.

Suggested change
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/lunr": "^2.3.3",
"lodash": "^4.17.21",
"lunr": "^2.3.9",
Expand Down
Loading