Skip to content

[Snyk] Fix for 2 vulnerabilities#4752

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f47148c543361d292c4329040dcbb791
Closed

[Snyk] Fix for 2 vulnerabilities#4752
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f47148c543361d292c4329040dcbb791

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Apr 16, 2025

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/config-schema/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Always-Incorrect Control Flow Implementation
SNYK-JS-HTTPPROXYMIDDLEWARE-9691387
  45  
medium severity Improper Check for Unusual or Exceptional Conditions
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Summary by Sourcery

Address security vulnerabilities by updating Backstage package dependencies to specific versions

Bug Fixes:

  • Fix two medium-severity vulnerabilities in http-proxy-middleware package

Enhancements:

  • Update Backstage core dependencies from workspace references to specific package versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 16, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented Apr 16, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 16, 2025

Reviewer's Guide by Sourcery

This pull request updates the @backstage/config, @backstage/core-components, and @backstage/core-plugin-api dependencies in plugins/config-schema/package.json to specific versions (0.1.1, 0.1.0, and 0.1.0 respectively) from workspace:^. This change is introduced by Snyk to address two vulnerabilities.

Updated class diagram for package.json dependencies

classDiagram
  class PackageJson {
    -dependencies: Object
    +updateDependencies(newDependencies: Object): void
  }

  note for PackageJson "Dependencies @backstage/config, @backstage/core-components, and @backstage/core-plugin-api updated to specific versions."
Loading

File-Level Changes

Change Details Files
Updates @backstage/config, @backstage/core-components, and @backstage/core-plugin-api dependencies to specific versions.
  • Updates @backstage/config from workspace:^ to 0.1.1.
  • Updates @backstage/core-components from workspace:^ to 0.1.0.
  • Updates @backstage/core-plugin-api from workspace:^ to 0.1.0.
plugins/config-schema/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Comment on lines +26 to +28
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed version numbers, which breaks the monorepo's dependency structure. In a monorepo, workspace:^ references ensure packages use local development versions rather than published ones.

The warning in the PR description confirms this issue: "Failed to update the yarn.lock, please update manually before merging."

To properly address these vulnerabilities:

  1. Keep the workspace:^ references in this file
  2. Update the vulnerable dependencies in the root package.json instead
  3. Then run yarn to update the lockfile

This approach maintains the monorepo integrity while still addressing the security vulnerabilities identified by Snyk.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-components": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 23, 2025
@github-actions github-actions Bot closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants