Skip to content

[Snyk] Fix for 1 vulnerabilities #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/techdocs-addons-test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/test-utils": "0.1.1",
"@backstage/theme": "0.1.1",
Comment on lines +41 to +44

@graphite-app graphite-app Bot May 4, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing workspace references with pinned versions (0.1.1) breaks the monorepo's dependency management system. Workspace references ensure all packages use compatible versions within the project, while pinned versions can lead to multiple versions of the same package being installed.

The PR also fails to update the yarn.lock file, which is required for these dependency changes to take effect properly.

Consider addressing the vulnerability by updating the affected transitive dependency directly or by upgrading all workspace packages together through the proper monorepo update process rather than pinning individual packages to specific versions.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/test-utils": "0.1.1",
"@backstage/theme": "0.1.1",
+ "@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",
+ "@backstage/test-utils": "workspace:^",
+ "@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down