Skip to content

[Snyk] Fix for 1 vulnerabilities#4901

Closed
snyk-io[bot] wants to merge 1 commit into
masterfrom
snyk-fix-bf53fbb55aaa26f4717c4fe8e31b0fa8
Closed

[Snyk] Fix for 1 vulnerabilities#4901
snyk-io[bot] wants to merge 1 commit into
masterfrom
snyk-fix-bf53fbb55aaa26f4717c4fe8e31b0fa8

Conversation

@snyk-io

@snyk-io snyk-io Bot commented Apr 27, 2025

Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/config-schema/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
low severity Insecure Randomness
SNYK-JS-FORMIDABLE-9788127
  508  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Insecure Randomness

Summary by Sourcery

Bug Fixes:

  • Fix insecure randomness vulnerability (SNYK-JS-FORMIDABLE-9788127).

@codesandbox

codesandbox Bot commented Apr 27, 2025

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app

restack-app Bot commented Apr 27, 2025

Copy link
Copy Markdown

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai

sourcery-ai Bot commented Apr 27, 2025

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

Updates dependency versions in plugins/config-schema/package.json to address a reported vulnerability.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update specific @backstage dependencies to newer versions.
  • Changed @backstage/config from workspace:^ to 0.1.1
  • Changed @backstage/core-components from workspace:^ to 0.1.0
  • Changed @backstage/core-plugin-api from workspace:^ to 0.1.0
plugins/config-schema/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@github-actions

github-actions Bot commented May 4, 2025

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 4, 2025
Comment on lines +26 to 31
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces inconsistent dependency management by changing some Backstage dependencies from workspace references to pinned versions while leaving others unchanged. This mixed approach could create compatibility issues between components.

The warning in the PR description about the failed yarn.lock update is particularly concerning, as it indicates the dependency changes weren't properly resolved.

Before merging, consider:

  1. Using a consistent approach for all Backstage dependencies (either all workspace references or all pinned versions)
  2. Ensuring the yarn.lock file is properly updated
  3. Verifying that the pinned versions (0.1.0, 0.1.1) are compatible with the rest of the codebase

While fixing the vulnerability is important, introducing inconsistent dependency management may create new issues.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-components": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions github-actions Bot removed the stale label May 4, 2025
@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 11, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants