Skip to content

[Snyk] Fix for 1 vulnerabilities #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/config-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
Comment on lines +26 to 31

@graphite-app graphite-app Bot May 4, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces inconsistent dependency management by changing some Backstage dependencies from workspace references to pinned versions while leaving others unchanged. This mixed approach could create compatibility issues between components.

The warning in the PR description about the failed yarn.lock update is particularly concerning, as it indicates the dependency changes weren't properly resolved.

Before merging, consider:

  1. Using a consistent approach for all Backstage dependencies (either all workspace references or all pinned versions)
  2. Ensuring the yarn.lock file is properly updated
  3. Verifying that the pinned versions (0.1.0, 0.1.1) are compatible with the rest of the codebase

While fixing the vulnerability is important, introducing inconsistent dependency management may create new issues.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-components": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Expand Down
Loading