Skip to content

[Snyk] Fix for 1 vulnerabilities #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dev-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
"@backstage/app-defaults": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog-react": "0.0.1",
Comment on lines +38 to +41
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed dependency changes replace workspace references with fixed, outdated versions (0.1.0, 0.1.1, 0.0.1). This approach is concerning for two reasons:

  1. These versions are extremely old and likely incompatible with the current codebase
  2. Pinning to specific versions in a monorepo instead of using workspace references breaks the internal dependency management

Additionally, the PR description warns that the yarn.lock file wasn't updated properly, which is critical for these changes to work correctly.

A better approach would be to:

  • Maintain the workspace:^ references
  • Address the vulnerability by updating the problematic dependency in the root package.json
  • Ensure yarn.lock is properly updated

This would fix the security issue while preserving the monorepo's dependency structure.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog-react": "0.0.1",
+ "@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
+ "@backstage/integration-react": "workspace:^",
+ "@backstage/plugin-catalog-react": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading