Skip to content

[Snyk] Fix for 1 vulnerabilities #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/github-deployments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +27 to +33
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a vulnerability but introduces significant compatibility risks by pinning dependencies to extremely outdated versions (0.0.1, 0.1.0, 0.1.1). These versions are likely much older than what the current workspace references resolve to.

Two critical issues with this approach:

  1. The yarn.lock file wasn't updated, meaning these changes won't properly take effect
  2. Using such old versions could break compatibility with the rest of the codebase

A better approach would be to:

  • Identify the minimum versions that fix the vulnerability but remain compatible
  • Ensure the yarn.lock file is properly updated
  • Consider using version ranges (e.g., ^0.15.0) rather than exact pins if appropriate

Please consult with Snyk about alternative remediation strategies that don't require downgrading to these early versions.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading