Skip to content

[Snyk] Fix for 1 vulnerabilities#5014

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-976741bb1670c55b8555d46579cbc1d0
Closed

[Snyk] Fix for 1 vulnerabilities#5014
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-976741bb1670c55b8555d46579cbc1d0

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 6, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/cli/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update package dependencies to resolve a security vulnerability in @babel/runtime

Bug Fixes:

  • Fix Regular Expression Denial of Service (ReDoS) vulnerability in dependencies

Enhancements:

  • Upgrade multiple package versions to their latest releases

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 6, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 6, 2025

Reviewer's Guide

This pull request, automatically generated by Snyk, addresses a Regular Expression Denial of Service (ReDoS) vulnerability. This is achieved by upgrading the versions of five direct dependencies in the packages/cli/package.json file. A critical point for review is that the yarn.lock file was not automatically updated and requires manual regeneration before merging.

File-Level Changes

Change Details Files
Dependencies upgraded to resolve security vulnerability.
  • Upgraded five dependencies: @backstage/catalog-model, @backstage/config-loader, @backstage/release-manifests, @manypkg/get-packages, and eslint-plugin-jsx-a11y.
  • The yarn.lock file was not updated by Snyk and requires manual regeneration.
packages/cli/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment thread packages/cli/package.json
Comment on lines +33 to +41
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace:^ references to fixed versions for Backstage packages will disrupt the monorepo development workflow. In a Yarn workspace setup, these workspace references are intentional - they ensure the CLI uses local workspace packages during development rather than pulling specific versions from the registry.

This modification appears to be an unintended side effect of the vulnerability fix. The proper approach would be to maintain the workspace:^ references for internal Backstage packages while only updating the external dependencies that contain the vulnerability (@manypkg/get-packages and eslint-plugin-jsx-a11y).

Consider reverting the changes to:

"@backstage/catalog-model": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/release-manifests": "workspace:^",

This preserves the monorepo development experience while still addressing the security vulnerability in the external dependencies.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 6, 2025

Snyk checks have failed. 1 issues have been found so far.

Icon Severity Issues
Critical 0
High 0
Medium 1
Low 0

⚠️ security/snyk check encountered an error. (View Details)

⚠️ license/snyk check encountered an error. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 13, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants