Skip to content

[Snyk] Fix for 1 vulnerabilities #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,18 @@
"backstage-cli": "bin/backstage-cli"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
Comment on lines +33 to +41
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace:^ references to fixed versions for Backstage packages will disrupt the monorepo development workflow. In a Yarn workspace setup, these workspace references are intentional - they ensure the CLI uses local workspace packages during development rather than pulling specific versions from the registry.

This modification appears to be an unintended side effect of the vulnerability fix. The proper approach would be to maintain the workspace:^ references for internal Backstage packages while only updating the external dependencies that contain the vulnerability (@manypkg/get-packages and eslint-plugin-jsx-a11y).

Consider reverting the changes to:

"@backstage/catalog-model": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/release-manifests": "workspace:^",

This preserves the monorepo development experience while still addressing the security vulnerability in the external dependencies.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@esbuild-kit/cjs-loader": "^2.4.1",
"@manypkg/get-packages": "^1.1.3",
"@manypkg/get-packages": "^2.0.0",
"@octokit/graphql": "^5.0.0",
"@octokit/graphql-schema": "^13.7.0",
"@octokit/oauth-app": "^4.2.0",
Expand Down Expand Up @@ -86,7 +86,7 @@
"eslint-plugin-deprecation": "^1.3.2",
"eslint-plugin-import": "^2.25.4",
"eslint-plugin-jest": "^27.0.0",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-jsx-a11y": "^6.9.0",
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.3.0",
"eslint-webpack-plugin": "^3.1.1",
Expand Down
Loading