Skip to content

[Snyk] Fix for 1 vulnerabilities#5024

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-74c71df8852d5eeac08547d0886a7a1b
Closed

[Snyk] Fix for 1 vulnerabilities#5024
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-74c71df8852d5eeac08547d0886a7a1b

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 6, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/code-coverage-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update package dependencies to fix a security vulnerability in the Babel runtime

Bug Fixes:

  • Resolve a Regular Expression Denial of Service (ReDoS) vulnerability in Babel runtime

Enhancements:

  • Update package versions for @backstage dependencies

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 6, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 6, 2025

Reviewer's Guide

This PR implements a fix for a ReDoS vulnerability. This was achieved by Snyk automatically updating three @backstage dependencies to specific, fixed versions within the plugins/code-coverage-backend/package.json file. A manual update to the yarn.lock file is required before merging this PR.

Sequence Diagram: Snyk Automated Fix and Developer's Manual yarn.lock Update

sequenceDiagram
    actor Developer
    participant Snyk
    participant Repository

    Snyk->>Repository: Scan `plugins/code-coverage-backend/package.json` for vulnerabilities
    alt Vulnerability Detected (SNYK-JS-BABELRUNTIME-10044504)
        Snyk->>Repository: Create PR (updates `package.json` dependency versions)
        activate Repository
        Repository-->>Developer: Notify: New PR from Snyk
        deactivate Repository
    end

    Developer->>Repository: Review PR (checks `package.json` changes)
    Developer->>Developer: Manually run `yarn` to update `yarn.lock`
    note right of Developer: This step is crucial as per PR warning.
    Developer->>Repository: Commit updated `yarn.lock` to PR branch
    Developer->>Repository: Merge PR
Loading

Class Diagram: package.json Dependency Version Updates

classDiagram
    class PackageJsonFile {
        <<File>>
        +filePath: "plugins/code-coverage-backend/package.json"
        +dependencies: JSON
    }
    note for PackageJsonFile "Updated dependency versions to fix vulnerability:
- @backstage/backend-common: 'workspace:^' -> '0.24.1'
- @backstage/catalog-client: 'workspace:^' -> '0.2.0'
- @backstage/config: 'workspace:^' -> '0.1.1'

Note: `yarn.lock` requires manual update by developer."
Loading

File-Level Changes

Change Details Files
Updated three @backstage dependencies to fixed versions to address a ReDoS vulnerability.
  • Updated @backstage/backend-common from workspace:^ to 0.24.1.
  • Updated @backstage/catalog-client from workspace:^ to 0.2.0.
  • Updated @backstage/config from workspace:^ to 0.1.1.
plugins/code-coverage-backend/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment on lines +26 to +29
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a vulnerability by replacing workspace references with fixed versions, but this approach is problematic in a Backstage monorepo.

The change from workspace:^ to fixed versions (0.24.1, 0.2.0, 0.1.1) breaks Backstage's internal dependency management system. In a monorepo, workspace references ensure that compatible versions are used across packages during development and build.

A better approach would be to:

  1. Keep the workspace:^ syntax for all internal dependencies
  2. Address the vulnerability by updating the affected package at the root level
  3. Run yarn install to propagate the fix throughout the workspace

This maintains compatibility while still addressing the security concern. The current approach will likely cause version conflicts and build issues.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 13, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants