Skip to content

[Snyk] Fix for 1 vulnerabilities #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/code-coverage-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
Comment on lines +26 to +29
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a vulnerability by replacing workspace references with fixed versions, but this approach is problematic in a Backstage monorepo.

The change from workspace:^ to fixed versions (0.24.1, 0.2.0, 0.1.1) breaks Backstage's internal dependency management system. In a monorepo, workspace references ensure that compatible versions are used across packages during development and build.

A better approach would be to:

  1. Keep the workspace:^ syntax for all internal dependencies
  2. Address the vulnerability by updating the affected package at the root level
  3. Run yarn install to propagate the fix throughout the workspace

This maintains compatibility while still addressing the security concern. The current approach will likely cause version conflicts and build issues.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@types/express": "^4.17.6",
Expand Down
Loading