[Snyk] Fix for 1 vulnerabilities#5032
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-BABELRUNTIME-10044504
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's GuideThis PR, automatically generated by Snyk, addresses a vulnerability by updating and pinning the versions of three yarn dependencies in Sequence Diagram for Snyk Vulnerability Fix ProcesssequenceDiagram
actor SnykSystem as Snyk
participant ProjectRepository as Repo
actor Developer
Snyk->>Repo: Scans yarn dependencies for vulnerabilities
Snyk->>Repo: Identifies ReDoS in babel-runtime (SNYK-JS-BABELRUNTIME-10044504)
Snyk->>Repo: Creates PR: updates 3 dependencies in 'plugins/catalog-import/package.json'
Snyk->>Repo: Adds PR warning: "Failed to update yarn.lock, please update manually."
Repo-->>Developer: Notifies about new Snyk PR
Developer->>Developer: Reviews PR (package.json changes)
Developer->>Developer: Manually updates 'yarn.lock' (e.g., runs 'yarn install')
note right of Developer: If using zero-installs, run 'yarn' to update '.yarn/cache/'
Developer->>Repo: Merges PR after testing
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/integration": "workspace:^", | ||
| "@backstage/integration-react": "workspace:^", | ||
| "@backstage/integration-react": "1.1.20", | ||
| "@backstage/plugin-catalog-common": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "0.0.1", |
There was a problem hiding this comment.
This PR's approach to fixing vulnerabilities is concerning. Replacing workspace:^ references with fixed, outdated versions (0.1.0, 0.0.1, 1.1.20) will likely break the application rather than secure it.
In a monorepo using Yarn workspaces, the workspace:^ references ensure packages use compatible versions from the same codebase. Downgrading to these specific old versions:
- Introduces version incompatibilities
- May add new bugs or breaking changes
- Doesn't properly address the underlying vulnerability
A better approach would be to:
- Keep the
workspace:^references intact - Update the vulnerable dependencies at their source within the monorepo
- If external dependencies are vulnerable, update those to secure versions while maintaining workspace references
Consider rejecting this PR and addressing the @babel/runtime ReDoS vulnerability through proper dependency management that preserves the workspace structure.
| "@backstage/core-components": "0.1.0", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/integration": "workspace:^", | |
| "@backstage/integration-react": "workspace:^", | |
| "@backstage/integration-react": "1.1.20", | |
| "@backstage/plugin-catalog-common": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", | |
| "@backstage/plugin-catalog-react": "0.0.1", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/integration": "workspace:^", | |
| "@backstage/integration-react": "workspace:^", | |
| "@backstage/plugin-catalog-common": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/catalog-import/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-BABELRUNTIME-10044504
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Summary by Sourcery
Update package dependencies to resolve a security vulnerability in @babel/runtime
Bug Fixes:
Enhancements: