Skip to content

[Snyk] Fix for 1 vulnerabilities #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@
"dependencies": {
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/types": "0.1.1",
Comment on lines +50 to +58
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a ReDoS vulnerability by replacing workspace references with pinned versions, but this approach is problematic for several reasons:

  1. Replacing workspace:^ references with specific versions (0.1.0, 0.1.1) breaks the project's workspace dependency structure
  2. The versions being pinned appear to be extremely outdated (0.1.x) and would likely be incompatible with the current codebase
  3. The warning in the PR description about failing to update yarn.lock suggests there are unresolved dependency conflicts

A more appropriate approach would be to address the vulnerability while maintaining the workspace references. Consider:

  • Updating the vulnerable dependency directly in the workspace packages
  • Using Yarn resolutions to override the vulnerable transitive dependency
  • Applying a patch if available

This change as proposed would likely cause more issues than it solves due to the significant version downgrades.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/types": "0.1.1",
+ "@backstage/core-components": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
+ "@backstage/theme": "workspace:^",
+ "@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading