Skip to content

[Snyk] Fix for 1 vulnerabilities#5043

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-7e5a67b5e1ee79d38d27bd66312d6fd5
Closed

[Snyk] Fix for 1 vulnerabilities#5043
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-7e5a67b5e1ee79d38d27bd66312d6fd5

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 6, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/bazaar/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Address a security vulnerability in Backstage dependencies by updating package versions

Bug Fixes:

  • Fix Regular Expression Denial of Service (ReDoS) vulnerability in Babel runtime

Enhancements:

  • Update Backstage core dependencies to specific versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 6, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 6, 2025

Reviewer's Guide

This automated Snyk pull request addresses a Regular Expression Denial of Service (ReDoS) vulnerability by updating yarn dependency versions in plugins/bazaar/package.json. Specifically, three @backstage packages were upgraded. Importantly, the yarn.lock file was not updated by this PR and requires manual regeneration before merging.

Sequence Diagram: Snyk PR and Developer Actions for Dependency Update

sequenceDiagram
    title "Sequence Diagram: Snyk PR and Developer Actions for Dependency Update"
    actor Developer
    participant Snyk
    participant GitHubRepo as "GitHub Repository"
    participant ProjectFiles as "Project Files (plugins/bazaar)"

    Snyk->>GitHubRepo: Scans for vulnerabilities
    GitHubRepo-->>Snyk: Vulnerability identified (e.g., in a transitive dependency like @babel/runtime)
    Snyk->>GitHubRepo: Creates Automated Pull Request
    Snyk->>ProjectFiles: Modifies package.json (updates @backstage/core-components, @backstage/plugin-catalog-react, @backstage/theme)
    Note right of Snyk: PR description warns: yarn.lock requires manual update.
    Developer->>GitHubRepo: Reviews Pull Request (sees package.json changes and warning)
    Developer->>ProjectFiles: Locally runs `yarn install` (or equivalent command)
    Note over Developer, ProjectFiles: yarn.lock is updated. If using zero-installs, .yarn/cache may also need to be updated/checked.
    Developer->>GitHubRepo: Commits updated yarn.lock to the PR branch
    Developer->>GitHubRepo: Merges Pull Request
Loading

File-Level Changes

Change Details Files
Upgraded versions of multiple @backstage dependencies to resolve a ReDoS vulnerability.
  • @backstage/core-components version updated from workspace:^ to 0.1.0.
  • @backstage/plugin-catalog-react version updated from workspace:^ to 0.0.1.
  • @backstage/theme version updated from workspace:^ to 0.1.1.
plugins/bazaar/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment on lines +28 to +33
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace dependencies with fixed, outdated versions which will disrupt the monorepo's dependency management system. In Yarn workspace projects, internal package dependencies should use the workspace:^ notation to maintain version consistency across the codebase.

The proposed changes pin to very old versions (0.0.1, 0.1.0, 0.1.1) which will likely cause compatibility issues with other plugins and components in the system.

Instead of downgrading to fixed versions, consider:

  1. Updating the vulnerable dependency while maintaining workspace references
  2. Addressing the vulnerability at its source within the monorepo
  3. If absolutely necessary, upgrading all affected packages together

The current approach will fix the vulnerability but introduce breaking changes to the dependency graph.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 6, 2025

Snyk checks have failed. 1 issues have been found so far.

Icon Severity Issues
Critical 0
High 0
Medium 1
Low 0

security/snyk check is complete. 1 issues have been found. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 13, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants