Skip to content

[Snyk] Fix for 1 vulnerabilities#5053

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-8375ea0f550cf1e7f09c895f804cdc92
Closed

[Snyk] Fix for 1 vulnerabilities#5053
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-8375ea0f550cf1e7f09c895f804cdc92

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 6, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/backend-common/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update dependencies to fix a vulnerability in @babel/runtime and resolve potential zero-install compatibility issues

Bug Fixes:

  • Resolve Regular Expression Denial of Service (ReDoS) vulnerability in @babel/runtime

Enhancements:

  • Update multiple Backstage and package dependencies to specific versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 6, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 6, 2025

Reviewer's Guide

Snyk automatically updated yarn dependency versions in packages/backend-common/package.json to remediate the ReDoS vulnerability SNYK-JS-BABELRUNTIME-10044504. Snyk has flagged these updates as potentially breaking. A manual update of yarn.lock is required before merging.

Sequence Diagram for Snyk Vulnerability Fix Process

sequenceDiagram
    participant Snyk
    participant "Code Repository"
    actor Developer

    Snyk->>"Code Repository": Scans for vulnerabilities
    "Code Repository"-->>Snyk: Reports vulnerability (e.g., SNYK-JS-BABELRUNTIME-10044504)
    Snyk->>"Code Repository": Creates Pull Request (updates package.json)
    Developer->>"Code Repository": Reviews Pull Request
    Developer->>"Code Repository": Manually updates yarn.lock
    note right of Developer: yarn.lock update required as per PR warning
    Developer->>"Code Repository": Merges Pull Request
Loading

File-Level Changes

Change Details Files
Yarn dependency versions were upgraded to address a security vulnerability.
  • Version of @backstage/backend-app-api upgraded to 0.7.6.
  • Version of @backstage/backend-plugin-api upgraded to 0.6.19.
  • Version of @backstage/config-loader upgraded to 1.5.1.
  • Version of @backstage/integration-aws-node upgraded to 0.1.0.
  • Version of @manypkg/get-packages upgraded to ^2.0.0.
packages/backend-common/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment on lines +53 to +61
"@backstage/backend-app-api": "0.7.6",
"@backstage/backend-dev-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/integration-aws-node": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes workspace dependencies from workspace:^ to fixed versions, which breaks the monorepo architecture. In a monorepo, internal packages should reference each other using workspace syntax to ensure proper local development and testing.

The warning in the PR description also indicates that the yarn.lock file needs updating, which is critical for dependency resolution.

For Backstage monorepos:

  1. Keep all internal dependencies as workspace:^ references
  2. Update the yarn.lock file to address the vulnerability
  3. Consider updating only the specific transitive dependency that contains the vulnerability rather than changing the workspace references

This approach will fix the security issue while maintaining the integrity of the monorepo structure.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 13, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants