Skip to content

[Snyk] Fix for 1 vulnerabilities #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/backend-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,21 @@
"@aws-sdk/client-s3": "^3.350.0",
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/types": "^3.347.0",
"@backstage/backend-app-api": "workspace:^",
"@backstage/backend-app-api": "0.7.6",
"@backstage/backend-dev-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "1.5.1",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/integration-aws-node": "0.1.0",
Comment on lines +53 to +61
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes workspace dependencies from workspace:^ to fixed versions, which breaks the monorepo architecture. In a monorepo, internal packages should reference each other using workspace syntax to ensure proper local development and testing.

The warning in the PR description also indicates that the yarn.lock file needs updating, which is critical for dependency resolution.

For Backstage monorepos:

  1. Keep all internal dependencies as workspace:^ references
  2. Update the yarn.lock file to address the vulnerability
  3. Consider updating only the specific transitive dependency that contains the vulnerability rather than changing the workspace references

This approach will fix the security issue while maintaining the integrity of the monorepo structure.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@google-cloud/storage": "^6.0.0",
"@keyv/memcache": "^1.3.5",
"@keyv/redis": "^2.5.3",
"@kubernetes/client-node": "0.18.1",
"@manypkg/get-packages": "^1.1.3",
"@manypkg/get-packages": "^2.0.0",
"@octokit/rest": "^19.0.3",
"@types/cors": "^2.8.6",
"@types/dockerode": "^3.3.0",
Expand Down