[Snyk] Fix for 1 vulnerabilities#5059
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-BABELRUNTIME-10044504
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's GuideThis pull request, automatically generated by Snyk, addresses a Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-BABELRUNTIME-10044504) by upgrading several "@backstage" dependencies in the "plugins/config-schema/package.json" file. The PR description indicates that the "yarn.lock" file requires a manual update before merging. Sequence Diagram: Snyk Vulnerability Fix and Manual Yarn Lock UpdatesequenceDiagram
actor Snyk
participant GitHubRepo as "GitHub Repository"
actor Developer
Snyk->>GitHubRepo: Scans project dependencies for vulnerabilities
Snyk->>GitHubRepo: Detects vulnerability (SNYK-JS-BABELRUNTIME-10044504)
Snyk->>GitHubRepo: Creates Pull Request updating 'plugins/config-schema/package.json'
note right of Snyk: PR does not update 'yarn.lock' automatically
Developer->>GitHubRepo: Reviews PR
Developer->>GitHubRepo: Manually updates 'yarn.lock' (e.g., by running 'yarn install')
Developer->>GitHubRepo: Merges PR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
| "@backstage/config": "0.1.1", | ||
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", | ||
| "@backstage/types": "workspace:^", |
There was a problem hiding this comment.
The dependency management approach in this PR is inconsistent and potentially problematic. Some Backstage dependencies are being pinned to specific versions (@backstage/config: 0.1.1, @backstage/core-components: 0.1.0, etc.) while others remain as workspace references (@backstage/errors: workspace:^, @backstage/types: workspace:^).
This mixed approach could lead to version compatibility issues between the Backstage packages. For proper dependency resolution, either:
- Pin all Backstage dependencies to specific versions, or
- Keep all Backstage dependencies as workspace references
Additionally, the PR description contains a warning that the yarn.lock update failed, which suggests these dependency changes may not be properly resolved in the lockfile. This should be addressed before merging to ensure the vulnerability fix is properly implemented without introducing new issues.
| "@backstage/config": "0.1.1", | |
| "@backstage/core-components": "0.1.0", | |
| "@backstage/core-plugin-api": "0.1.0", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/theme": "0.1.1", | |
| "@backstage/types": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/types": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
⛔ Snyk checks have failed. 1 issues have been found so far.
⛔ security/snyk check is complete. 1 issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/config-schema/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-BABELRUNTIME-10044504
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Summary by Sourcery
Update Backstage package dependencies to resolve a security vulnerability
Bug Fixes:
Enhancements: