Skip to content

[Snyk] Fix for 1 vulnerabilities#5059

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-54a9bc18779e91e967b24c77572dfe18
Closed

[Snyk] Fix for 1 vulnerabilities#5059
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-54a9bc18779e91e967b24c77572dfe18

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 6, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/config-schema/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Summary by Sourcery

Update Backstage package dependencies to resolve a security vulnerability

Bug Fixes:

  • Fix a Regular Expression Denial of Service (ReDoS) vulnerability in Babel runtime

Enhancements:

  • Update Backstage core package dependencies from workspace references to specific versions

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 6, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 6, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 6, 2025

Reviewer's Guide

This pull request, automatically generated by Snyk, addresses a Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-BABELRUNTIME-10044504) by upgrading several "@backstage" dependencies in the "plugins/config-schema/package.json" file. The PR description indicates that the "yarn.lock" file requires a manual update before merging.

Sequence Diagram: Snyk Vulnerability Fix and Manual Yarn Lock Update

sequenceDiagram
    actor Snyk
    participant GitHubRepo as "GitHub Repository"
    actor Developer

    Snyk->>GitHubRepo: Scans project dependencies for vulnerabilities
    Snyk->>GitHubRepo: Detects vulnerability (SNYK-JS-BABELRUNTIME-10044504)
    Snyk->>GitHubRepo: Creates Pull Request updating 'plugins/config-schema/package.json'
    note right of Snyk: PR does not update 'yarn.lock' automatically
    Developer->>GitHubRepo: Reviews PR
    Developer->>GitHubRepo: Manually updates 'yarn.lock' (e.g., by running 'yarn install')
    Developer->>GitHubRepo: Merges PR
Loading

File-Level Changes

Change Details Files
Upgraded @backstage dependencies to fix a ReDoS vulnerability.
  • Updated "@backstage/config" from "workspace:^" to "0.1.1".
  • Updated "@backstage/core-components" from "workspace:^" to "0.1.0".
  • Updated "@backstage/core-plugin-api" from "workspace:^" to "0.1.0".
  • Updated "@backstage/theme" from "workspace:^" to "0.1.1".
  • The "yarn.lock" file needs to be updated manually before merging.
plugins/config-schema/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Comment on lines +26 to 31
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/types": "workspace:^",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency management approach in this PR is inconsistent and potentially problematic. Some Backstage dependencies are being pinned to specific versions (@backstage/config: 0.1.1, @backstage/core-components: 0.1.0, etc.) while others remain as workspace references (@backstage/errors: workspace:^, @backstage/types: workspace:^).

This mixed approach could lead to version compatibility issues between the Backstage packages. For proper dependency resolution, either:

  1. Pin all Backstage dependencies to specific versions, or
  2. Keep all Backstage dependencies as workspace references

Additionally, the PR description contains a warning that the yarn.lock update failed, which suggests these dependency changes may not be properly resolved in the lockfile. This should be addressed before merging to ensure the vulnerability fix is properly implemented without introducing new issues.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 6, 2025

Snyk checks have failed. 1 issues have been found so far.

Icon Severity Issues
Critical 0
High 0
Medium 1
Low 0

security/snyk check is complete. 1 issues have been found. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 13, 2025
@github-actions github-actions Bot closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants