Skip to content

[Snyk] Fix for 1 vulnerabilities #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/core-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/version-bridge": "0.1.0",
Comment on lines +35 to +39
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace:^ to fixed versions (0.1.1, 0.1.0) for Backstage packages breaks the workspace dependency pattern. This prevents the use of local versions during development and may lead to version inconsistencies across the project.

Unless there's a specific requirement to pin these dependencies to exact versions, these references should remain as workspace:^ to maintain proper workspace functionality and development workflow.

The vulnerability fix for @material-table/core can be applied independently without changing the workspace references for the Backstage packages.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/version-bridge": "0.1.0",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
+ "@backstage/theme": "workspace:^",
+ "@backstage/version-bridge": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@date-io/core": "^1.3.13",
"@material-table/core": "^3.1.0",
"@material-table/core": "^4.3.45",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading