Skip to content

[Snyk] Fix for 1 vulnerabilities #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-graph/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"dependencies": {
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +27 to +30
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a vulnerability but introduces problematic dependency versioning. The specified versions (0.1.0, 0.0.1, 0.1.1) are extremely outdated and likely incompatible with the current project structure.

The original dependencies use workspace references (workspace:^), which is the recommended approach for Backstage plugins. Replacing these with fixed, outdated versions will likely break functionality and create version conflicts.

The warning in the PR description ("Failed to update the yarn.lock") confirms these compatibility issues.

Instead of merging as-is, consider:

  1. Addressing the vulnerability while maintaining workspace references
  2. If specific versions must be pinned, use versions compatible with your current Backstage implementation
  3. Ensuring the yarn.lock file updates correctly with any dependency changes

The vulnerability should be addressed, but not at the cost of breaking the plugin's integration with the rest of the project.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading