Skip to content

[Snyk] Fix for 1 vulnerabilities #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/gitops-profiles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +36 to +39
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates inconsistency in dependency management by converting some Backstage dependencies to fixed versions (@backstage/config, @backstage/core-components, @backstage/theme) while leaving @backstage/core-plugin-api as a workspace reference. This mixed approach may lead to version compatibility issues between these tightly coupled packages.

Additionally, the PR description contains a warning that the yarn.lock file was not updated successfully. This needs to be resolved before merging to ensure proper dependency resolution.

Consider either:

  1. Converting all Backstage dependencies to fixed versions consistently
  2. Keeping all as workspace references
  3. Ensuring the yarn.lock file is properly updated to reflect these changes
Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
+ "@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading