Skip to content

[Snyk] Fix for 1 vulnerabilities #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/lighthouse/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-lighthouse-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-lighthouse-common": "0.1.0",
"@backstage/theme": "0.1.1",
Comment on lines +38 to +42
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references (workspace:^) with pinned versions, which breaks the monorepo architecture pattern. In a monorepo, workspace references ensure that plugins use the local versions of packages, maintaining compatibility across the codebase.

The warning in the PR description about failing to update the yarn.lock file further suggests these changes may cause integration problems.

For Backstage monorepos, the recommended approach is to keep the workspace:^ references intact and address vulnerabilities by updating the shared packages at their source rather than pinning versions in individual plugins.

Consider rejecting this PR and instead addressing the @babel/runtime ReDoS vulnerability through a proper monorepo-wide dependency update.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-lighthouse-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-lighthouse-common": "0.1.0",
"@backstage/theme": "0.1.1",
+ "@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
+ "@backstage/plugin-catalog-react": "workspace:^",
+ "@backstage/plugin-lighthouse-common": "workspace:^",
+ "@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading