Skip to content

[Snyk] Fix for 1 vulnerabilities #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-ldap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +35 to +40
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace dependencies with fixed, significantly older versions that are likely incompatible with the current codebase. Changing from workspace:^ to specific versions (0.6.1, 0.1.1, 0.1.0, 1.0.0) breaks the local dependency resolution mechanism that ensures compatible versions are used throughout the project.

The warning in the PR description about failing to update yarn.lock confirms these compatibility issues. While addressing the vulnerability is important, this approach will likely introduce breaking changes and regressions.

A better approach would be to:

  1. Keep the workspace:^ references intact
  2. Update the vulnerable dependency at the workspace root level
  3. Regenerate the yarn.lock file properly

This ensures the vulnerability is fixed while maintaining compatibility across the project.

Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
+ "@backstage/backend-tasks": "workspace:^",
+ "@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
+ "@backstage/plugin-catalog-common": "workspace:^",
+ "@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@types/ldapjs": "^2.2.0",
"ldapjs": "^2.2.0",
Expand Down
Loading