Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/circleci/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +37 to +40
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace:^ references with fixed version numbers, which is problematic for Backstage's monorepo architecture. The workspace:^ syntax ensures that local package versions are used during development, maintaining consistency across the codebase.

Pinning to specific versions (especially older ones like 0.0.1 and 0.1.0) will likely:

  1. Create version conflicts with other plugins
  2. Break functionality that depends on newer features
  3. Disrupt the monorepo's dependency resolution

To address the vulnerability while preserving the monorepo structure, consider:

  • Updating the affected transitive dependency directly
  • Using Yarn resolutions to override the vulnerable package
  • Upgrading the affected package across the entire monorepo

The PR should maintain the workspace:^ references while addressing the security issue through one of these alternative approaches.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading