Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/integration-aws-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/types": "^3.347.0",
"@aws-sdk/util-arn-parser": "^3.310.0",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^"
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1"
Comment on lines +40 to +41
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes workspace references to fixed versions (0.1.1), which breaks the monorepo architecture. In a monorepo, packages should reference each other using workspace:^ to ensure they use local versions during development rather than published packages.

Changing to fixed versions:

  1. Prevents local development changes from propagating between packages
  2. May cause version inconsistencies across the codebase
  3. Defeats the purpose of using a monorepo

The security fix should be applied while maintaining the workspace:^ references to preserve the monorepo functionality.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1"
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

},
"devDependencies": {
"@backstage/cli": "workspace:^",
Expand Down
Loading