Skip to content

[Snyk] Fix for 1 vulnerabilities #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/home-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +36 to +37
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from workspace references to fixed version 0.1.0 for Backstage core packages is problematic for several reasons:

  1. Version 0.1.0 appears to be significantly outdated for Backstage components
  2. Replacing workspace references with fixed versions defeats the purpose of a monorepo setup
  3. The PR failed to update the yarn.lock file as noted in the warning

This change would likely introduce compatibility issues rather than just fixing the vulnerability.

A better approach would be to:

  • Keep the workspace references (workspace:^)
  • Update the vulnerable dependencies at their source within the monorepo
  • Run yarn to properly update the lockfile

If fixed versions are required, use current compatible versions rather than downgrading to 0.1.0.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@rjsf/utils": "5.7.3"
Expand Down
Loading