Skip to content

[Snyk] Fix for 1 vulnerabilities #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/newrelic-dashboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
Comment on lines +26 to +29

@graphite-app graphite-app Bot May 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency changes in this PR are concerning as they replace workspace references with significantly outdated versions:

  • @backstage/core-components: 0.1.0 (released in early 2021)
  • @backstage/core-plugin-api: 0.1.0
  • @backstage/plugin-catalog-react: 0.0.1

These versions are incompatible with current Backstage components, which have evolved considerably since these early releases. The warning about the failed yarn.lock update further indicates these changes aren't properly resolved.

To properly address the ReDoS vulnerability in Babel runtime, consider:

  1. Maintaining the workspace references (workspace:^)
  2. Updating the root package dependencies instead
  3. If specific versions must be used, select current compatible versions (check the latest Backstage release for appropriate version numbers)

This approach would fix the vulnerability without breaking compatibility with the rest of the Backstage ecosystem.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down