Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
"@backstage/plugin-proxy-backend": "workspace:^",
"@backstage/plugin-rollbar-backend": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-backend-module-confluence-to-markdown": "workspace:^",
"@backstage/plugin-scaffolder-backend-module-rails": "workspace:^",
"@backstage/plugin-scaffolder-backend-module-confluence-to-markdown": "0.2.1",
"@backstage/plugin-scaffolder-backend-module-rails": "0.1.1",
Comment on lines +65 to +66
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning these dependencies to specific versions (0.2.1 and 0.1.1) while the PR warning indicates the yarn.lock file wasn't updated creates a risk of dependency resolution issues. This approach deviates from the workspace reference pattern used by other dependencies, which could lead to compatibility problems between Backstage components.

Consider either:

  1. Maintaining workspace references (workspace:^) and updating yarn.lock properly
  2. Ensuring all affected dependencies are pinned consistently with a comprehensive yarn.lock update

This is particularly important in a monorepo structure where components expect consistent versioning across the workspace.

Suggested change
"@backstage/plugin-scaffolder-backend-module-confluence-to-markdown": "0.2.1",
"@backstage/plugin-scaffolder-backend-module-rails": "0.1.1",
"@backstage/plugin-scaffolder-backend-module-confluence-to-markdown": "workspace:^",
"@backstage/plugin-scaffolder-backend-module-rails": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-search-backend": "workspace:^",
"@backstage/plugin-search-backend-module-elasticsearch": "workspace:^",
"@backstage/plugin-search-backend-module-pg": "workspace:^",
Expand All @@ -72,7 +72,7 @@
"@backstage/plugin-tech-insights-backend": "workspace:^",
"@backstage/plugin-tech-insights-backend-module-jsonfc": "workspace:^",
"@backstage/plugin-tech-insights-node": "workspace:^",
"@backstage/plugin-techdocs-backend": "workspace:^",
"@backstage/plugin-techdocs-backend": "0.1.1",
"@backstage/plugin-todo-backend": "workspace:^",
"@gitbeaker/node": "^35.1.0",
"@octokit/rest": "^19.0.3",
Expand Down
Loading