Skip to content

[Snyk] Fix for 1 vulnerabilities #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/codescene/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "0.1.1",
"@backstage/theme": "0.1.1",
Comment on lines +25 to +29
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed versions, which breaks the monorepo structure. In a Backstage monorepo, dependencies between internal packages should use workspace:^ references to ensure consistent versioning across the project.

Fixed versions will likely cause:

  1. Version mismatches between related packages
  2. Development workflow issues
  3. Difficulty testing local changes across packages

The warning in the PR description about the failed yarn.lock update confirms this issue. While addressing the security vulnerability is important, it should be done while preserving the workspace references (workspace:^).

Consider updating the underlying dependencies that contain the vulnerability while maintaining the workspace reference pattern.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/errors": "0.1.1",
"@backstage/theme": "0.1.1",
+ "@backstage/config": "workspace:^",
+ "@backstage/core-components": "workspace:^",
+ "@backstage/core-plugin-api": "workspace:^",
+ "@backstage/errors": "workspace:^",
+ "@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading