Skip to content

[Snyk] Fix for 1 vulnerabilities #5219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/search-backend-module-catalog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^"
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1"
Comment on lines +41 to +48
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR attempts to fix a ReDoS vulnerability in Babel runtime by pinning specific package versions, but it's incomplete. The warning "Failed to update the yarn.lock" indicates that the lockfile hasn't been updated, which means the vulnerability will remain despite the package.json changes.

For this fix to be effective:

  1. The PR needs to include the updated yarn.lock file
  2. Pinning specific versions (0.6.1, 0.1.0, etc.) instead of using workspace references (workspace:^) in a monorepo setup may cause version conflicts with other packages

Consider either:

  • Updating this PR to include the modified yarn.lock file
  • Using a different approach that maintains workspace references while addressing the vulnerability

Without the lockfile update, merging this PR won't actually resolve the security issue.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

},
"devDependencies": {
"@backstage/backend-common": "workspace:^",
Expand Down
Loading