Skip to content

[Snyk] Fix for 1 vulnerabilities #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core-plugin-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
Comment on lines +48 to +50
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed versions, which could disrupt the monorepo's dependency management. Using specific versions (0.1.1 and 0.1.0) instead of workspace references (workspace:^) means these packages will be pulled from the registry rather than using local versions.

While this addresses the security vulnerability, it may introduce version inconsistencies across the monorepo. Consider either:

  1. Updating the vulnerable dependency within the workspace structure instead
  2. Ensuring all related packages are updated to compatible versions
  3. Testing thoroughly to verify no integration issues arise from this change

The warning about failing to update yarn.lock suggests additional manual work will be needed before merging.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/react": "^16.13.1 || ^17.0.0",
"history": "^5.0.0",
"prop-types": "^15.7.2",
Expand Down
Loading