Skip to content

[Snyk] Fix for 1 vulnerabilities #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #5236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-openapi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
"@apidevtools/json-schema-ref-parser": "^9.0.6",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "1.25.0",
"@backstage/plugin-catalog-common": "0.1.0",
Comment on lines +38 to +41
Copy link
Copy Markdown

@graphite-app graphite-app Bot May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references (workspace:^) with fixed versions, which disrupts the monorepo's dependency management system. In a Backstage monorepo, workspace references ensure that packages use local versions of dependencies, maintaining version consistency across the project.

Fixed versions like "@backstage/config": "0.1.1" will cause:

  1. Version mismatches between packages
  2. Potential build failures
  3. Difficulty in local development

The vulnerability fix should be implemented while preserving the workspace references. Consider using Yarn's resolutions field in the root package.json to address the vulnerability without breaking the workspace structure.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "1.25.0",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/config": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/types": "workspace:^",
"winston": "^3.2.1",
Expand Down
Loading