Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-msgraph/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
"@azure/identity": "^3.2.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +51 to +55
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specified package versions (0.1.1, 0.1.0, 1.0.0) appear significantly outdated for Backstage, which is a mature project. These versions are likely incorrect and could introduce compatibility issues with other dependencies or reintroduce security vulnerabilities that were fixed in later releases.

Before merging, it would be advisable to:

  1. Verify these versions against the latest compatible releases
  2. Consider using version ranges with ^ prefix instead of pinned versions
  3. Check if these versions are compatible with the rest of the workspace dependencies

The warning in the PR description about failing to update the yarn.lock file may be related to these version inconsistencies.

Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
+ "@backstage/backend-tasks": "^0.6.1",
+ "@backstage/catalog-model": "^1.4.0",
"@backstage/config": "workspace:^",
+ "@backstage/plugin-catalog-common": "^1.0.14",
+ "@backstage/plugin-catalog-node": "^1.3.7",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@microsoft/microsoft-graph-types": "^2.6.0",
"@types/node-fetch": "^2.5.12",
"lodash": "^4.17.21",
Expand Down
Loading